eqmk
/
qmk_firmware
forked from mfulz_github/qmk_firmware
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Make CPPCheck tool happy by altering the program flow in the low level keyboard example, so that the SendReport variable is not overwritten before its first read access.

This commit is contained in:
Dean Camera 2012-09-13 20:30:00 +00:00
parent c93259fbdb
commit df14c97519
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Demos/Device/LowLevel/Keyboard/Keyboard.c
View File

@ -294,14 +294,11 @@ void SendNextReport(void)
{ {
static USB_KeyboardReport_Data_t PrevKeyboardReportData; static USB_KeyboardReport_Data_t PrevKeyboardReportData;
USB_KeyboardReport_Data_t KeyboardReportData; USB_KeyboardReport_Data_t KeyboardReportData;
bool SendReport = true; bool SendReport = false;
/* Create the next keyboard report for transmission to the host */ /* Create the next keyboard report for transmission to the host */
CreateKeyboardReport(&KeyboardReportData); CreateKeyboardReport(&KeyboardReportData);
/* Check to see if the report data has changed - if so a report MUST be sent */
SendReport = (memcmp(&PrevKeyboardReportData, &KeyboardReportData, sizeof(USB_KeyboardReport_Data_t)) != 0);
/* Check if the idle period is set and has elapsed */ /* Check if the idle period is set and has elapsed */
if (IdleCount && (!(IdleMSRemaining))) if (IdleCount && (!(IdleMSRemaining)))
{ {
@ -311,6 +308,11 @@ void SendNextReport(void)
/* Idle period is set and has elapsed, must send a report to the host */ /* Idle period is set and has elapsed, must send a report to the host */
SendReport = true; SendReport = true;
} }
else
{
/* Check to see if the report data has changed - if so a report MUST be sent */
SendReport = (memcmp(&PrevKeyboardReportData, &KeyboardReportData, sizeof(USB_KeyboardReport_Data_t)) != 0);
}
/* Select the Keyboard Report Endpoint */ /* Select the Keyboard Report Endpoint */
Endpoint_SelectEndpoint(KEYBOARD_IN_EPADDR); Endpoint_SelectEndpoint(KEYBOARD_IN_EPADDR);